-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support seed from N space points #3645
Conversation
9fb0598
to
34cdeb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Can you verify this doesn't have runtime performance effects?
Quality Gate passedIssues Measures |
@paulgessinger some timing studies show no runtime performance effects |
also @paulgessinger be aware this requires a full build of Athena, not a partial one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Future support for seeds created from
N
space points, withN >= 3
.The seed EDM naturally support the possibility of requiring more than 3 space points, so the Seed class is now templated on both the external space point type and the required number of space points:
Seed<external_spacepoint_t, N>
.By default
N == 3
, and there is a requirement thatN >= 3
.The default values is to avoid a breaking change in the code.
This PR requires #3432