Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support seed from N space points #3645

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

CarloVarni
Copy link
Collaborator

Future support for seeds created from N space points, with N >= 3.
The seed EDM naturally support the possibility of requiring more than 3 space points, so the Seed class is now templated on both the external space point type and the required number of space points: Seed<external_spacepoint_t, N>.

By default N == 3, and there is a requirement that N >= 3.
The default values is to avoid a breaking change in the code.

This PR requires #3432

@CarloVarni CarloVarni added this to the v37.0.0 milestone Sep 24, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Documentation Affects the documentation Event Data Model Seeding Track Finding labels Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

📊: Physics performance monitoring for eca61d9

Full contents

physmon summary

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Can you verify this doesn't have runtime performance effects?

Core/include/Acts/EventData/Seed.hpp Outdated Show resolved Hide resolved
Core/include/Acts/EventData/Seed.hpp Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 30, 2024

@CarloVarni
Copy link
Collaborator Author

@paulgessinger some timing studies show no runtime performance effects

@CarloVarni
Copy link
Collaborator Author

also @paulgessinger be aware this requires a full build of Athena, not a partial one

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit a45d452 into acts-project:main Sep 30, 2024
44 checks passed
@CarloVarni CarloVarni deleted the ND-Seed branch September 30, 2024 15:39
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Event Data Model Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants