Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: FPE safe eta/theta conversion #3788

Merged
merged 17 commits into from
Nov 7, 2024
Merged

refactor: FPE safe eta/theta conversion #3788

merged 17 commits into from
Nov 7, 2024

Commits on Oct 28, 2024

  1. refactor: FPE safe eta/theta conversion

    @andiwand
    andiwand committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f6f0767 View commit details
    Browse the repository at this point in the history

  2. experiment with FPEs

    @andiwand
    andiwand committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    5e130b7 View commit details
    Browse the repository at this point in the history

  3. fix track selector tests

    @andiwand
    andiwand committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    2c22146 View commit details
    Browse the repository at this point in the history

  4. use std::floating_point

    @andiwand
    andiwand committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    e1c3261 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. pr feedback

    @andiwand
    andiwand committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f645945 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Merge branch 'main' into fpe-safe-eta-theta-conversion

    @andiwand
    andiwand authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    eaf6094 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. provide clamped impl

    @andiwand
    andiwand committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    2a411cd View commit details
    Browse the repository at this point in the history

  2. test corners

    @andiwand
    andiwand committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a1cbdbb View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Tim Adye <T.J.Adye@rl.ac.uk>
    @andiwand @timadye
    andiwand and timadye authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    aa33d08 View commit details
    Browse the repository at this point in the history

  4. pr feedback

    @andiwand
    andiwand committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    1e56b8c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fpe-safe-eta-theta-conversion' of github.com:andiwand/a… 

    …cts into fpe-safe-eta-theta-conversion
    @andiwand
    andiwand committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    3fd43bc View commit details
    Browse the repository at this point in the history

  6. nuke clamped conversion

    @andiwand
    andiwand committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    91e82cb View commit details
    Browse the repository at this point in the history

  7. drop corner tests

    @andiwand
    andiwand committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    e8d9d18 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Tim Adye <T.J.Adye@rl.ac.uk>
    @andiwand @timadye
    andiwand and timadye authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    5a220d7 View commit details
    Browse the repository at this point in the history

  2. Update Core/include/Acts/Utilities/AngleHelpers.hpp 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @andiwand @coderabbitai
    andiwand and coderabbitai[bot] authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    345e426 View commit details
    Browse the repository at this point in the history

  3. Update Core/include/Acts/Utilities/AngleHelpers.hpp

    @andiwand
    andiwand authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e5550eb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fpe-safe-eta-theta-conversion

    @andiwand
    andiwand authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f92f144 View commit details
    Browse the repository at this point in the history