Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csv-stringify): update quoted_match confug option to accept arrays #371

Merged
merged 3 commits into from
Nov 30, 2022
Merged

fix(csv-stringify): update quoted_match confug option to accept arrays #371

merged 3 commits into from
Nov 30, 2022

Conversation

mariuszste
Copy link
Contributor

@mariuszste mariuszste commented Nov 29, 2022

This pull request updates the type definition for the quoted_match config option in csv-stringify to allow for array variants. The support for it is is already there but the types are outdated.

@wdavidw
Copy link
Member

wdavidw commented Nov 29, 2022

Would you have the courage to add a test coverage in "test/api.types.ts", that would be great.

@mariuszste
Copy link
Contributor Author

Done

@wdavidw wdavidw merged commit 42c468b into adaltas:master Nov 30, 2022
@wdavidw
Copy link
Member

wdavidw commented Nov 30, 2022

Thanks, this is perfect!

@mariuszste mariuszste deleted the update-types branch November 30, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants