Implement move_to
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
reviewed
Jul 8, 2020
There was a problem hiding this comment.
Thank you for this.
Your PR was missing docs and a changelog note. When engaging with open source projects please try to figure out how the project maintains its documentation and add them in the same way. It really helps with maintenance. One day I will get around to adding a contribution guide to my repos to say this.
I'm adding the changelog and docs, and test improvements in a follow-up PR.
| def test_move_to_datetime_when_tick(): | ||
| with time_machine.travel(EPOCH, tick=True) as traveller: | ||
| traveller.move_to(EPOCH_PLUS_ONE_YEAR_DATETIME) | ||
| assert time.time() == pytest.approx(EPOCH_PLUS_ONE_YEAR) |
There was a problem hiding this comment.
approx not as good as using the 'bounds checking' method in the other tests (<=) because it's not clear how many decimal places are checked, and it would potentially allow time to tick backwards
Merged
|
Released in version 1.2.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes towards #20