Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientation change after closing the keyboard temporarily confuses the viewport #1

Open
BarnabasSzabolcs opened this issue Nov 30, 2021 · 2 comments

Comments

@BarnabasSzabolcs
Copy link

BarnabasSzabolcs commented Nov 30, 2021

Hi Adam!

First of all, awesome work, also with the demo page!

I have tested it thoroughly on iPhone 7 Safari iOS 13.7 and it is very robust, gets the keyboard height right, even if I change languages, which changes the keyboard height.

The "issue": if I'm in landscape mode and I close the edit then I change to portrait within a second, the viewport acts as if the keyboard was still open in portrait mode. (but it goes back to working normal if I open and close the keyboard again, and I expect my users to rarely use their phone in landscape mode so it is more than fine for me...)

@BarnabasSzabolcs BarnabasSzabolcs changed the title Orientation change after closing the keyboard confuses the viewport Orientation change after closing the keyboard temporarily confuses the viewport Nov 30, 2021
@adamjgrant
Copy link
Owner

Thanks for filing this, @BarnabasSzabolcs when I circle back to this I'll take a look to see if I can fix it, otherwise, please feel free to send a PR if you find a solution. Thanks.

@BarnabasSzabolcs
Copy link
Author

I'll do if I find time to examine. It'll be surely some fun if I do get down to fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants