Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency on next-server #30

Closed
AndrewRayCode opened this issue Mar 24, 2019 · 2 comments
Closed

Dependency on next-server #30

AndrewRayCode opened this issue Mar 24, 2019 · 2 comments

Comments

@AndrewRayCode
Copy link

I'm not fully up to speed on the guts of next, but I'm using a custom express server with my next app. Installing next-server just to get execOnce seems like a lot? Context: I (apparently ) don't have next-server installed locally so when I changed next to a peerdependency in my fork of this project, and installed my fork locally, it didn't work.
@adamsoffer
Copy link
Owner

Yeah, we should definitely remove that dependency. Thanks for pointing this out!

@adamsoffer
Copy link
Owner

This dep has been removed as of v3.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndrewRayCode @adamsoffer