Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scissorRect is clipping points even through their pointSize would overlap the scissorRect #1

Open
adamwulf opened this issue Sep 8, 2016 · 1 comment
Labels

Comments

@adamwulf
Copy link
Owner

adamwulf commented Sep 8, 2016

The scissor rect clips points according to their center, not according to their center + pointSize. This can lead to some strange artifacts during undo/redo or when changing the rotation of the highlighter which causes a re-render of all strokes around the start point.

simulator screen shot sep 8 2016 2 42 42 am

Possible solutions:

  1. don't use scissor test at all, which is what I've done for now to keep rendering correct at the expense of speed, or
  2. use quads instead of points, which will raise point memory by 4x, which might be ok
@adamwulf adamwulf added the bug label Sep 8, 2016
adamwulf added a commit that referenced this issue Sep 8, 2016
…oint is barely outside the scissorRect. the points are clipped based on their center, not their center + pointSize. #1
@adamwulf
Copy link
Owner Author

adamwulf commented Sep 8, 2016

This recent commit simply turns off scissor test altogether to err on the side of render accuracy over speed. To fix would probably require quads instead of points, which would be at least a tradeoff of memory and may affect performance elsewhere as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant