Fix FedAdam and FedYogi to match the paper (#885)

Co-authored-by: Pedro Porto Buarque de Gusmão <pedropgusmao@gmail.com>
adap · Oct 28, 2021 · 1b8dc4c · 1b8dc4c
1 parent df34a20
commit 1b8dc4c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/py/flwr/server/strategy/fedyogi.py b/src/py/flwr/server/strategy/fedyogi.py
@@ -152,7 +152,7 @@ def aggregate_fit(
             self.v_t = [np.zeros_like(x) for x in self.delta_t]
 
         self.v_t = [
-            x + (1.0 - self.beta_2) * np.multiply(y, y) * np.sign(x - np.multiply(y, y))
+            x - (1.0 - self.beta_2) * np.multiply(y, y) * np.sign(x - np.multiply(y, y))
             for x, y in zip(self.v_t, self.delta_t)
         ]