Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove timeout attribute from ServerMessage #1198

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Remove timeout attribute from ServerMessage #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/proto/flwr/proto/transport.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ message ServerMessage {
EvaluateIns evaluate_ins = 4;
PropertiesIns properties_ins = 5;
}

// When the field is not explicitly set it will default to zero in gRPC
// therefore all implementations using it should treat 0 as no timeout
float timeout = 20;
}

message ClientMessage {
Expand Down
95 changes: 44 additions & 51 deletions src/py/flwr/proto/transport_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 1 addition & 8 deletions src/py/flwr/proto/transport_pb2.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ class ServerMessage(google.protobuf.message.Message):
FIT_INS_FIELD_NUMBER: builtins.int
EVALUATE_INS_FIELD_NUMBER: builtins.int
PROPERTIES_INS_FIELD_NUMBER: builtins.int
TIMEOUT_FIELD_NUMBER: builtins.int
@property
def reconnect(self) -> global___ServerMessage.Reconnect: ...
@property
Expand All @@ -198,22 +197,16 @@ class ServerMessage(google.protobuf.message.Message):
def evaluate_ins(self) -> global___ServerMessage.EvaluateIns: ...
@property
def properties_ins(self) -> global___ServerMessage.PropertiesIns: ...
timeout: builtins.float
"""When the field is not explicitly set it will default to zero in gRPC
therefore all implementations using it should treat 0 as no timeout
"""

def __init__(self,
*,
reconnect: typing.Optional[global___ServerMessage.Reconnect] = ...,
get_parameters: typing.Optional[global___ServerMessage.GetParameters] = ...,
fit_ins: typing.Optional[global___ServerMessage.FitIns] = ...,
evaluate_ins: typing.Optional[global___ServerMessage.EvaluateIns] = ...,
properties_ins: typing.Optional[global___ServerMessage.PropertiesIns] = ...,
timeout: builtins.float = ...,
) -> None: ...
def HasField(self, field_name: typing_extensions.Literal["evaluate_ins",b"evaluate_ins","fit_ins",b"fit_ins","get_parameters",b"get_parameters","msg",b"msg","properties_ins",b"properties_ins","reconnect",b"reconnect"]) -> builtins.bool: ...
def ClearField(self, field_name: typing_extensions.Literal["evaluate_ins",b"evaluate_ins","fit_ins",b"fit_ins","get_parameters",b"get_parameters","msg",b"msg","properties_ins",b"properties_ins","reconnect",b"reconnect","timeout",b"timeout"]) -> None: ...
def ClearField(self, field_name: typing_extensions.Literal["evaluate_ins",b"evaluate_ins","fit_ins",b"fit_ins","get_parameters",b"get_parameters","msg",b"msg","properties_ins",b"properties_ins","reconnect",b"reconnect"]) -> None: ...
def WhichOneof(self, oneof_group: typing_extensions.Literal["msg",b"msg"]) -> typing.Optional[typing_extensions.Literal["reconnect","get_parameters","fit_ins","evaluate_ins","properties_ins"]]: ...
global___ServerMessage = ServerMessage

Expand Down