Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing in state #1675

Merged
merged 13 commits into from
Feb 20, 2023
Merged

Improve testing in state #1675

merged 13 commits into from
Feb 20, 2023

Conversation

tanertopal
Copy link
Member

What does this implement/fix? Explain your changes.

Improve testing in state

Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I added a few suggestions.

@danieljanes danieljanes mentioned this pull request Feb 20, 2023
tanertopal and others added 12 commits February 20, 2023 16:41
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
…tate

* 'improve_state' of github.com:adap/flower:
  Update src/py/flwr/server/state/state_test.py
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@tanertopal tanertopal merged commit e87d18f into main Feb 20, 2023
@tanertopal tanertopal deleted the improve_state branch February 20, 2023 19:21
tanertopal added a commit that referenced this pull request Feb 20, 2023
* main:
  Improve testing in state (#1675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants