Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new quickstart example TabNet #1725

Merged
merged 9 commits into from
Mar 23, 2023
Merged

Add a new quickstart example TabNet #1725

merged 9 commits into from
Mar 23, 2023

Conversation

m-danilow
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Flower has many great examples for various frameworks/architectures, etc., but lacks examples for tabular data which is very popular. TabNet provides a high-performance and interpretable tabular data deep learning architecture. The example utilizes the iris dataset for classification.

Any other comments?

Base of example comes from -> repo
Details about TabNet -> paper

As this is my first PR in this repo feedback will be appreciated :)

Co-authored-by: Taner Topal <taner@adap.com>
@tanertopal
Copy link
Member

@m-danilow really cool example! Thank you for it! On my first quick glance, I started making suggestions but then thought maybe you could run poetry run python -m black -q examples from the repo root directory once so it's autoformatted in the default style.

@m-danilow
Copy link
Contributor Author

@tanertopal thanks, I didn't know black package before :)

@tanertopal
Copy link
Member

tanertopal commented Mar 21, 2023

@tanertopal thanks, I didn't know black package before :)

Yea, it resolves all discussions about formatting. :)

@tanertopal tanertopal self-assigned this Mar 22, 2023
@tanertopal tanertopal added the enhancement New feature or request label Mar 22, 2023
@tanertopal
Copy link
Member

@m-danilow The PR looks good to me! @charlesbvll is going to have a look as well tomorrow. Afterwards, we can merge it! Thanks so much! I would be excited to have a short call to understand your background. Let me know if you would be in for it here or on Slack.

Short sidenote: We have to fix a dependency issue related to tensorflow-cpu, which might slightly delay merging your example.

@tanertopal tanertopal enabled auto-merge (squash) March 23, 2023 15:46
@tanertopal tanertopal merged commit fe0c27f into adap:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants