Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework) Update subprocess launch mechanism for simulation plugin #3826

Merged
merged 7 commits into from
Jul 17, 2024
Merged

feat(framework) Update subprocess launch mechanism for simulation plugin #3826

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
45e4abc
init
jafermarq Jul 17, 2024
483da71
fix?
jafermarq Jul 17, 2024
f1d5b7c
Merge branch 'main' into temp-logs-in-superexec
Moep90 Jul 17, 2024
b16d9f8
Merge branch 'main' into temp-logs-in-superexec
Moep90 Jul 17, 2024
9b646ed
Merge branch 'main' into temp-logs-in-superexec
Moep90 Jul 17, 2024
38ac543
Merge branch 'main' into temp-logs-in-superexec
jafermarq Jul 17, 2024
6ee52a8
handle `RunTracker`
jafermarq Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/py/flwr/superexec/simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,18 +125,17 @@ def start_run(
command.extend(["--run-config", f"{override_config}"])

# Start Simulation
proc = subprocess.Popen( # pylint: disable=consider-using-with
proc = subprocess.run( # pylint: disable=consider-using-with
command,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
check=True,
text=True,
)

log(INFO, "Started run %s", str(run_id))

return RunTracker(
run_id=run_id,
proc=proc,
proc=proc, # type:ignore
)

# pylint: disable-next=broad-except
Expand Down