buffer: fix MAX_LENGTH constant export

This was a typo and accidentally returned the wrong value. Fixes: nodejs#14819 Ref: nodejs#13467
addaleax · Aug 14, 2017 · 12ba74e · 12ba74e
1 parent 314217f
commit 12ba74e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -76,7 +76,7 @@ Buffer.prototype = FastBuffer.prototype;
 
 const constants = Object.defineProperties({}, {
   MAX_LENGTH: {
-    value: kStringMaxLength,
+    value: kMaxLength,
     writable: false,
     enumerable: true
   },

diff --git a/test/parallel/test-buffer-constants.js b/test/parallel/test-buffer-constants.js
@@ -2,6 +2,7 @@
 require('../common');
 const assert = require('assert');
 
+const { kMaxLength, kStringMaxLength } = require('buffer');
 const { MAX_LENGTH, MAX_STRING_LENGTH } = require('buffer').constants;
 
 assert.strictEqual(typeof MAX_LENGTH, 'number');
@@ -11,3 +12,7 @@ assert.throws(() => ' '.repeat(MAX_STRING_LENGTH + 1),
               /^RangeError: Invalid string length$/);
 
 assert.doesNotThrow(() => ' '.repeat(MAX_STRING_LENGTH));
+
+// Legacy values match:
+assert.strictEqual(kMaxLength, MAX_LENGTH);
+assert.strictEqual(kStringMaxLength, MAX_STRING_LENGTH);