Skip to content

Commit

Permalink
deps: limit regress/regress-crbug-514081 v8 test
Browse files Browse the repository at this point in the history
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs#6340
PR-URL: nodejs#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
  • Loading branch information
mhdawson authored and addaleax committed Sep 13, 2017
1 parent 3cbe154 commit 6a7017c
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions deps/v8/test/mjsunit/mjsunit.status
Original file line number Diff line number Diff line change
Expand Up @@ -646,4 +646,13 @@
'mjsunit-assertion-error' : [SKIP],
}], # no_harness

##############################################################################
# This test allocates a 2G block of memory and if there are multiple
# varients this leads kills by the OOM killer, crashes or messages
# indicating the OS cannot allocate memory, exclude for Node.js runs
# re-evalute when we move up to v8 5.1
[ALWAYS, {
'regress/regress-crbug-514081': [PASS, NO_VARIANTS],
}], # ALWAYS

]

0 comments on commit 6a7017c

Please sign in to comment.