Skip to content

Commit

Permalink
tools: fix mkcodecache when run with ASAN
Browse files Browse the repository at this point in the history
Fixes: nodejs#32835

PR-URL: nodejs#32850
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
  • Loading branch information
addaleax committed Apr 28, 2020
1 parent 51f05d2 commit 9cc253c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions tools/code_cache/mkcodecache.cc
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ int main(int argc, char* argv[]) {

// Create a new Isolate and make it the current one.
Isolate::CreateParams create_params;
create_params.array_buffer_allocator =
ArrayBuffer::Allocator::NewDefaultAllocator();
create_params.array_buffer_allocator_shared.reset(
ArrayBuffer::Allocator::NewDefaultAllocator());
Isolate* isolate = Isolate::New(create_params);
{
Isolate::Scope isolate_scope(isolate);
Expand All @@ -65,6 +65,7 @@ int main(int argc, char* argv[]) {
out << cache;
out.close();
}
isolate->Dispose();

v8::V8::ShutdownPlatform();
return 0;
Expand Down

0 comments on commit 9cc253c

Please sign in to comment.