Skip to content

Commit

Permalink
src: avoid std::make_unique for now
Browse files Browse the repository at this point in the history
This broke Travis CI. We have run into this problem with
`std::make_unique` in the past, and opted to not use it
for now, e.g. in nodejs#20386.
  • Loading branch information
addaleax committed Oct 24, 2018
1 parent 449c0ca commit b669f96
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/env.cc
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ Environment::Environment(IsolateData* isolate_data,
AssignToContext(context, ContextInfo(""));

if (tracing::AgentWriterHandle* writer = GetTracingAgentWriter()) {
trace_state_observer_ = std::make_unique<TrackingTraceStateObserver>(this);
trace_state_observer_.reset(new TrackingTraceStateObserver(this));
v8::TracingController* tracing_controller = writer->GetTracingController();
if (tracing_controller != nullptr)
tracing_controller->AddTraceStateObserver(trace_state_observer_.get());
Expand Down

0 comments on commit b669f96

Please sign in to comment.