-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(barman): Adjust slot-creation #631
Conversation
For the |
thank you! i will look into it tomorrow |
The
Can you elaborate? |
I also added the possibility to add annotations. This could be useful in a few cases. |
I didn't realise that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Hello, creating a slot failed on our side because
ERROR: Unknown server 'pg'
.I found it hardcoded in the cronjob.
Wouldn't it be better to use the
postgres.host
value for creating the db slot?Let me know what you think!
Best
Issues
Checklist
pre-commit run
docs/