Hey @huextrat,

Thank you very much for the PR! We'll try to ship the patch update with this change soon. Will keep you posted.

@huextrat, one question about this issue. How did you see this error manifesting on your end? I was trying to reproduce the error in Expo app which uses TypeScript and having following in _layout.tsx worked without any issues for me:

import { Adjust, AdjustConfig, AdjustDeeplink } from "react-native-adjust";
....
const adjustConfig = new AdjustConfig("2fm9gkqubvpc", AdjustConfig.EnvironmentSandbox);
adjustConfig.setLogLevel(AdjustConfig.LogLevelVerbose);
Adjust.initSdk(adjustConfig);
Adjust.processDeeplink(new AdjustDeeplink("url"));

Indeed, AdjustDeeplink is not exported as class, but inside of my app I'm observing that things work even with AdjustDeeplink being declared as interface. 🤔

@uerceg You should have a TS2693 error: https://github.com/bennycode/typescript-errors/blob/main/errors/includes/TS2xxx/TS2693.md

I made a quick repro here https://github.com/huextrat/adjust-reproducer-246 with Expo and TypeScript:

https://github.com/huextrat/adjust-reproducer-246/blob/9d91317b97eaa78ee5cca1a1f4afb5e8248ab20f/app/_layout.tsx#L21-L24

Amazing, I'll try to reproduce the issue with your example app. Thank you very much for providing the example app.

Hey @huextrat,

Sorry for similar ping, but I am still unable to reproduce this error on my end, even with your app. Is this error supposed to be printed in native logs? I'm checking adb logcat logs for Android app and everything that Console app dumps for the iOS app process and I am not seeing the error anywhere (and weirdly enough, I do see sdk_click package with source=deeplink being tracked which pretty much means that this line executes successfully).

I'm attaching everything that iOS process shows in logs when I run your example app.

logs.txt

Any advice on what I might be doing wrong and not reproducing this issue? (also, just for the record to mention that I'm not experienced at all in some serious app development in Expo)

Hi @uerceg, this doesn't cause any problems at runtime, it's a TypeScript problem.

If you completely remove index.d.ts, the library will still work even with TypeScript, but types will be in error.

To reproduce, I've updated the reproducer repo with a script to run typescript lint (tsc): yarn lint:typescript

When executing this script typescript should indicate an error but as I said, it's “just” a typing error, so it's not a problem for the library to work properly :) But I assume that every developer who uses this library with a TypeScript configuration will get this type error on AdjustDeeplink.

Many thanks for the enlightenment. TIL.

And I really like this last commit of yours on the reproducer repo, I'll definitely be using that approach from now on. :)

I believe I'm now well equipped to reproduce and test the fix, so hopefully patch update is gonna be there soon.

Okay, replacing this one with #247. Thank you very much for all the effort.

Also, I have noticed that with your changes if one would attempt to access (to what used to be interface named AdjustDeeplink) .deeplink field inside of the deferred deep link callback, with AdjustDeeplink being just a class with constructor that's setting .deeplink member, there was also error being fired. So I renamed the interface to make a clear distinction between the AdjustDeeplink that's being injected by clients and AdjustDeferredDeeplink that's being sent back from Adjust to users.

Looking forward to hearing back from you if v5.0.1 works as expected on your end.

Thx @uerceg, it's great like that 👍

And thank you for all the work and feedback one more time, really appreciate it.