Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1315 - JS of CIF Core Components should be loaded via theme clientlib #233

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

mhaack
Copy link
Contributor

@mhaack mhaack commented Mar 20, 2020

Description

JS of CIF Core Components should be loaded via theme clientlib. This PR removes the direct loading of component clientlibs for the respective components. The clientlibs are embed by a project clientlib, see CIF archetype PR: adobe/aem-cif-project-archetype#97

Related Issue

CIF-1315

Motivation and Context

JS of CIF Core Components should be loaded via theme clientlib to follow the same pattern as WCM Core Components

How Has This Been Tested?

manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #233 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #233   +/-   ##
=========================================
  Coverage     60.36%   60.36%           
  Complexity      554      554           
=========================================
  Files           147      147           
  Lines          4395     4395           
  Branches        740      740           
=========================================
  Hits           2653     2653           
  Misses         1657     1657           
  Partials         85       85           
Flag Coverage Δ Complexity Δ
#jest 38.45% <ø> (ø) 0.00 <ø> (ø)
#karma 95.12% <ø> (ø) 0.00 <ø> (ø)
#unittests 85.44% <ø> (ø) 554.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06eadb...f686556. Read the comment docs.

@cjelger cjelger merged commit 5b50ebb into master Mar 24, 2020
@cjelger cjelger deleted the issues/CIF-1315 branch March 24, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request To Verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants