Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Venia loading indicator (logo.svg) via CSS #312

Merged
merged 4 commits into from
Jun 24, 2020
Merged

Conversation

laurentiumagureanu
Copy link
Collaborator

Description

Loading image (logo.svg) should be loaded from the site theme client lib.
The loading image is now loaded as background via CSS

Related Issue

CIF-1427

Motivation and Context

The logo.svg is hard coded in https://github.com/adobe/aem-core-cif-components/blob/master/react-components/src/components/LoadingIndicator/indicator.js

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #312 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #312   +/-   ##
=========================================
  Coverage     64.88%   64.88%           
  Complexity      809      809           
=========================================
  Files           184      184           
  Lines          5639     5639           
  Branches        875      875           
=========================================
  Hits           3659     3659           
  Misses         1852     1852           
  Partials        128      128           
Flag Coverage Δ Complexity Δ
#jest 43.02% <ø> (ø) 0.00 <ø> (ø)
#karma 94.51% <ø> (ø) 0.00 <ø> (ø)
#unittests 85.77% <ø> (ø) 809.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...nents/src/components/LoadingIndicator/indicator.js 100.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcaa9b6...337a270. Read the comment docs.

@herzog31 herzog31 added bug Something isn't working verified labels Jun 24, 2020
@herzog31 herzog31 merged commit 007cc44 into master Jun 24, 2020
@herzog31 herzog31 deleted the issues/CIF-1427 branch June 24, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants