Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1549 - Catalog option 'Show landing page' / commerce tab does not show up under page properties #355

Merged
merged 7 commits into from
Aug 4, 2020

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Jul 30, 2020

  • fixed commerce tab in catalog page properties
  • improved unit tests added IT

Related Issue

CIF-1549

How Has This Been Tested?

Manually, JUnit, IT.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

… show up under page properties

 * fixed commerce tab in catalog page properties
 * improved unit tests added IT
@LSantha LSantha added the bug Something isn't working label Jul 30, 2020
… show up under page properties

 * fixing IT failure
… show up under page properties

 * fixing IT failure
@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #355 into master will decrease coverage by 1.26%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #355      +/-   ##
============================================
- Coverage     84.52%   83.26%   -1.27%     
- Complexity      852      855       +3     
============================================
  Files           174      164      -10     
  Lines          4400     3877     -523     
  Branches        587      590       +3     
============================================
- Hits           3719     3228     -491     
+ Misses          555      522      -33     
- Partials        126      127       +1     
Flag Coverage Δ Complexity Δ
#integration 67.10% <14.28%> (+0.24%) 631.00 <0.00> (+3.00)
#jest 77.36% <ø> (ø) 0.00 <ø> (ø)
#karma ? ?
#unittests 85.80% <71.42%> (-0.02%) 824.00 <0.00> (+3.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ernal/servlets/PageTypeRenderConditionServlet.java 73.33% <71.42%> (+5.33%) 12.00 <0.00> (+3.00)
...ent/teaser/v1/teaser/clientlib/editor/js/teaser.js
...ctteaser/v1/productteaser/clientlibs/js/actions.js
...ps/core/cif/clientlibs/common/js/PriceFormatter.js
...ommerce/product/v1/product/clientlib/js/gallery.js
...product/v1/product/clientlib/js/variantSelector.js
...ore/cif/clientlibs/common/js/CommerceGraphqlApi.js
...vigation/v1/navigation/clientlibs/js/navigation.js
...merce/product/v1/product/clientlib/js/addToCart.js
...oductcollection/clientlibs/js/productcollection.js
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f27adc5...cf2a6f9. Read the comment docs.

… show up under page properties

 * fixed name of constants
@dplaton dplaton merged commit 51c28ac into master Aug 4, 2020
@dplaton dplaton deleted the CIF-1549 branch August 4, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants