Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1779 - CIF components build fails with java 8 #456

Merged
merged 2 commits into from
Dec 16, 2020
Merged

CIF-1779 - CIF components build fails with java 8 #456

merged 2 commits into from
Dec 16, 2020

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Dec 16, 2020

  • fix unit test issues with java 8
  • enable new CircleCI job to build with java 8

- fix unit test issues with java 8
@cjelger cjelger added bug Something isn't working testing labels Dec 16, 2020
- do not run ITs if java-8 build fails
@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #456 (aec1b6b) into master (13c2807) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #456   +/-   ##
=========================================
  Coverage     85.66%   85.66%           
  Complexity     1108     1108           
=========================================
  Files           225      225           
  Lines          5600     5600           
  Branches        810      810           
=========================================
  Hits           4797     4797           
  Misses          649      649           
  Partials        154      154           
Flag Coverage Δ Complexity Δ
integration 65.80% <ø> (ø) 0.00 <ø> (ø)
jest 80.02% <ø> (ø) 0.00 <ø> (ø)
karma 94.54% <ø> (ø) 0.00 <ø> (ø)
unittests 86.29% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c2807...aec1b6b. Read the comment docs.

@cjelger cjelger merged commit 8ebbd52 into master Dec 16, 2020
@cjelger cjelger deleted the CIF-1779 branch December 16, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants