Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1462 - Increase the coverage of the source code related to the Se… #484

Merged
merged 2 commits into from
Feb 11, 2021

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Feb 10, 2021

…arch feature

  • extend unit tests

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #484 (082d1e2) into master (8f83768) will increase coverage by 0.63%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #484      +/-   ##
============================================
+ Coverage     86.16%   86.80%   +0.63%     
- Complexity     1170     1188      +18     
============================================
  Files           229      229              
  Lines          5783     5783              
  Branches        846      846              
============================================
+ Hits           4983     5020      +37     
+ Misses          636      613      -23     
+ Partials        164      150      -14     
Flag Coverage Δ Complexity Δ
integration 64.69% <0.00%> (ø) 0.00 <0.00> (ø)
jest 81.25% <ø> (ø) 0.00 <ø> (ø)
karma 94.54% <ø> (ø) 0.00 <ø> (ø)
unittests 87.74% <100.00%> (+1.24%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...rch/internal/services/SearchFilterServiceImpl.java 100.00% <100.00%> (+29.78%) 20.00 <0.00> (+6.00)
...ch/internal/services/SearchResultsServiceImpl.java 98.42% <100.00%> (+11.51%) 61.00 <0.00> (+11.00)
...core/search/internal/models/SearchOptionsImpl.java 100.00% <0.00%> (+2.94%) 18.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f83768...082d1e2. Read the comment docs.

Copy link
Contributor

@dplaton dplaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! No more coverage drops because of these classes!

@cjelger cjelger merged commit eb9a082 into master Feb 11, 2021
@cjelger cjelger deleted the CIF-1462 branch February 11, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants