Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2182: use v2 for product and product list #610

Merged
merged 9 commits into from
Jul 14, 2021
Merged

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Jul 6, 2021

Description

Updates the CIF Examples to use the latest version of product and productlist component.

Related Issue

CIF-2182

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@buuhuu buuhuu marked this pull request as draft July 6, 2021 09:33
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #610 (858df36) into master (33b0f9d) will decrease coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #610      +/-   ##
============================================
- Coverage     88.37%   88.35%   -0.02%     
- Complexity     1453     1458       +5     
============================================
  Files           268      268              
  Lines          6527     6543      +16     
  Branches        977      985       +8     
============================================
+ Hits           5768     5781      +13     
  Misses          573      573              
- Partials        186      189       +3     
Flag Coverage Δ
integration 63.88% <37.50%> (+0.65%) ⬆️
jest 85.34% <ø> (ø)
karma 94.83% <ø> (ø)
unittests 88.05% <87.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ommerce/core/examples/servlets/GraphqlServlet.java 91.20% <87.50%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33b0f9d...858df36. Read the comment docs.

@buuhuu buuhuu marked this pull request as ready for review July 7, 2021 09:07
@herzog31 herzog31 added the enhancement New feature or request label Jul 8, 2021
@mhaack mhaack merged commit 80890e8 into master Jul 14, 2021
@mhaack mhaack deleted the issue/CIF-2182 branch July 14, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants