-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-2291 - Cleanups in searchbar component #655
Conversation
* added version 2 for the following components to make them usable in the page editor: accountedtails, addressbook, minicart, resetpassword, searchbar, miniaccount
* fixed link in README.md
* typo in README.md
* new CSS classes according to BEM methodology * default minimal styling * added v2 for searchber clientlib * fixed search field reset button * added text field for placeholder property in edit dialog * updated readme
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
============================================
+ Coverage 88.51% 88.57% +0.05%
Complexity 1598 1598
============================================
Files 281 282 +1
Lines 7079 7131 +52
Branches 1047 1047
============================================
+ Hits 6266 6316 +50
- Misses 616 618 +2
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* fixes in edit dialog
# Conflicts: # ui.apps/src/main/content/jcr_root/apps/core/cif/components/commerce/searchbar/v2/searchbar/.content.xml # ui.apps/src/main/content/jcr_root/apps/core/cif/components/commerce/searchbar/v2/searchbar/README.md # ui.apps/src/main/content/jcr_root/apps/core/cif/components/commerce/searchbar/v2/searchbar/searchbar.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but same problem like in the other PR. Why adding tests to Venia only and not in the components repo? The feature should be tested in this repo.
* added unit tests for searchbar
Related Issue
CIF-2291
How Has This Been Tested?
Manually, unit tests, UI tests.
Types of changes
Checklist: