Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2291 - Cleanups in searchbar component #655

Merged
merged 15 commits into from
Aug 25, 2021
Merged

CIF-2291 - Cleanups in searchbar component #655

merged 15 commits into from
Aug 25, 2021

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Aug 12, 2021

  • new CSS classes according to BEM methodology
  • default minimal styling
  • added v2 for searchber clientlib
  • fixed search field reset button
  • added text field for placeholder property in edit dialog
  • updated readme

Related Issue

CIF-2291

How Has This Been Tested?

Manually, unit tests, UI tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

 * added version 2 for the following components to make them usable in the page editor: accountedtails, addressbook, minicart, resetpassword, searchbar, miniaccount
 * new CSS classes according to BEM methodology
 * default minimal styling
 * added v2 for searchber clientlib
 * fixed search field reset button
 * added text field for placeholder property in edit dialog
 * updated readme
@LSantha LSantha marked this pull request as draft August 12, 2021 18:55
@LSantha LSantha added the enhancement New feature or request label Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #655 (f3cd57b) into master (96b8b8d) will increase coverage by 0.05%.
The diff coverage is 96.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #655      +/-   ##
============================================
+ Coverage     88.51%   88.57%   +0.05%     
  Complexity     1598     1598              
============================================
  Files           281      282       +1     
  Lines          7079     7131      +52     
  Branches       1047     1047              
============================================
+ Hits           6266     6316      +50     
- Misses          616      618       +2     
  Partials        197      197              
Flag Coverage Δ
integration 59.56% <ø> (ø)
jest 85.61% <ø> (ø)
karma 90.01% <96.15%> (+0.40%) ⬆️
unittests 89.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../searchbar/v2/searchbar/clientlibs/js/searchbar.js 96.15% <96.15%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b8b8d...f3cd57b. Read the comment docs.

Base automatically changed from CIF-1502 to master August 17, 2021 11:05
# Conflicts:
#	ui.apps/src/main/content/jcr_root/apps/core/cif/components/commerce/searchbar/v2/searchbar/.content.xml
#	ui.apps/src/main/content/jcr_root/apps/core/cif/components/commerce/searchbar/v2/searchbar/README.md
#	ui.apps/src/main/content/jcr_root/apps/core/cif/components/commerce/searchbar/v2/searchbar/searchbar.html
@LSantha LSantha marked this pull request as ready for review August 17, 2021 15:44
Copy link
Member

@herzog31 herzog31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but same problem like in the other PR. Why adding tests to Venia only and not in the components repo? The feature should be tested in this repo.

@herzog31 herzog31 merged commit 8ae7e0e into master Aug 25, 2021
@herzog31 herzog31 deleted the CIF-2291 branch August 25, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants