CIF-2272 - Cannot close category filter accordion once it is open

[LSantha]

Fix closing a filter when it's already opened.

Related Issue

CIF-2272

How Has This Been Tested?

Manually, unit test, UI test.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes and the overall coverage did not decrease.
• All unit tests pass on CircleCi.
• I ran all tests locally and they pass.

[codecov]

Codecov Report

Merging #656 (fdccf1d) into master (1cf426e) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #656      +/-   ##
============================================
+ Coverage     88.44%   88.51%   +0.06%     
  Complexity     1598     1598              
============================================
  Files           280      281       +1     
  Lines          6986     7079      +93     
  Branches       1047     1047              
============================================
+ Hits           6179     6266      +87     
- Misses          610      616       +6     
  Partials        197      197              

Flag	Coverage Δ
integration	59.56% <ø> (ø)
jest	85.61% <ø> (ø)
karma	89.60% <100.00%> (+0.53%)	⬆️
unittests	89.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...oductcollection/clientlibs/js/productcollection.js	93.54% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cf426e...fdccf1d. Read the comment docs.

[herzog31]

There should be a test for this change. Like https://github.com/adobe/aem-core-cif-components/blob/master/ui.apps/test/components/commerce/productcollection/productCollectionTest.js.

[LSantha]

@herzog31 , I've added a UI test already. See the Venia PR: adobe/aem-cif-guides-venia#179

[herzog31]

@LSantha Venia tests are not executed when changes are done in the components repo. So there should be a test in this repo. Can be a UI test or preferably a unit test.

[LSantha]

I've added a unit test.