Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2279 - Improve accessibility of carousel components #666

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

herzog31
Copy link
Member

Description

  • Removed invalid aria roles.
  • Changed button positioning (in DOM only), so that both buttons are in tab order before the cards.
  • Added title and aria-label to buttons.
  • Updated CSS to includes styles to differentiate between disabled and focused (via keyboard only) states of the buttons.
  • Updated markup in unit test.

How Has This Been Tested?

  • Manually tested by using the components via keyboard only.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added the bug Something isn't working label Aug 23, 2021
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #666 (e4231fc) into master (99972f6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #666   +/-   ##
=========================================
  Coverage     88.44%   88.44%           
  Complexity     1598     1598           
=========================================
  Files           280      280           
  Lines          6986     6986           
  Branches       1047     1047           
=========================================
  Hits           6179     6179           
  Misses          610      610           
  Partials        197      197           
Flag Coverage Δ
integration 59.56% <ø> (ø)
jest 85.61% <ø> (ø)
karma 89.06% <ø> (ø)
unittests 89.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99972f6...e4231fc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants