Skip to content

Commit

Permalink
SITES-26750 Accordion : Content editor dialog is adding "None" twice …
Browse files Browse the repository at this point in the history
…in Expanded Items field (#2890)

* Accordion : Content editor dialog is adding "None" twice in Expanded items field #2656 - Update accordion.js

#2656

* Update accordion.js comments

* Minor text/formatting fixes

* Revert "Minor text/formatting fixes"

This reverts commit e9806cd.

* Revert "Update accordion.js comments"

This reverts commit affc079.

* Revert "Accordion : Content editor dialog is adding "None" twice in Expanded items field #2656 - Update accordion.js"

This reverts commit bb4b3b4.

* Clean up all elements, not just ones with "" value

---------

Co-authored-by: Ranjani-JSB <jayaranjani.jayaprakash@corebridgefinancial.com>
  • Loading branch information
RaduADumitru and Ranjani-JSB authored Nov 12, 2024
1 parent 081c26d commit 77dd95c
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,7 @@
function updateExpandedSelect(childrenEditor, expandedSelect, expandedItemValues, singleExpansion) {
var selectedValues = (expandedSelect.values.length) ? expandedSelect.values : expandedItemValues;
expandedSelect.items.getAll().forEach(function(item) {
if (item.value !== "") {
expandedSelect.items.remove(item);
}
expandedSelect.items.remove(item);
});

var cmpChildrenEditor = $(childrenEditor).adaptTo("cmp-childreneditor");
Expand Down

0 comments on commit 77dd95c

Please sign in to comment.