Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating archetype dispatcher.cloud configuration to version 2.0.191 #1141

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

krystiannowak
Copy link
Collaborator

sync dispatcher immutable files with Dispatcher SDK and image v2.0.191

Description

Since the previous sync of dispatcher immutable files with Dispatcher SDK and image was from version 2.0.166 in February 2023 and AEM CS releases already progressed further, including dispatcher image and SDK tooling containing newer files, it resulted already in customer using latest public AEM CS releases being out of sync and reporting issues like #1043

Hence we propose to sync those files with the ones from the latest Dispatcher SDK and image v2.0.191 in order for validation scripts not to fail in immutable files compatibility check step as described in https://experienceleague.adobe.com/docs/experience-manager-cloud-service/content/implementing/content-delivery/validation-debug.html?lang=en#third-phase

Related Issue

#1043

Motivation and Context

Not to fail immutable files validation step described in https://experienceleague.adobe.com/docs/experience-manager-cloud-service/content/implementing/content-delivery/validation-debug.html?lang=en#third-phase when using Dispatcher SDK tooling from the latest AEM CS releases.

How Has This Been Tested?

$ bin/validate.sh /Users/krystian/devel/adobe/skyline/skyline-dispatcher-sdk/aem-project-archetype/src/main/archetype/dispatcher.cloud/src
opt-in USE_SOURCES_DIRECTLY marker file detected
Phase 1: Dispatcher validator
Cloud manager validator 2.0.62
2023/10/04 13:40:11 No issues found
Phase 1 finished successfully
Phase 2: httpd -t validation in docker image
(...)
VirtualHost configuration:
*:80                   is a NameVirtualHost
         default server publish (/etc/httpd/conf.d/enabled_vhosts/default.vhost:14)
         port 80 namevhost publish (/etc/httpd/conf.d/enabled_vhosts/default.vhost:14)
                 wild alias *
         port 80 namevhost unmatched-host-catch-all (/etc/httpd/conf.d/dispatcher_vhost.conf:284)
                 wild alias *
Phase 2 finished successfully
Phase 3: Immutability check
empty mode param, assuming mode = 'check'
running in 'check' mode
running in 'check' mode
reading immutable file list from /etc/httpd/immutable.files.txt
checking 'conf.d/available_vhosts/default.vhost' immutability (if present)
checking existing 'conf.d/available_vhosts/default.vhost' for changes
checking 'conf.d/dispatcher_vhost.conf' immutability (if present)
replacing include directive in 'conf.d/dispatcher_vhost.conf' before proceeding
checking existing 'conf.d/dispatcher_vhost.conf' for changes
checking 'conf.d/enabled_vhosts/vhosts.conf' immutability (if present)
checking existing 'conf.d/enabled_vhosts/vhosts.conf' for changes
checking 'conf.d/rewrites/default_rewrite.rules' immutability (if present)
checking existing 'conf.d/rewrites/default_rewrite.rules' for changes
checking 'conf.dispatcher.d/available_farms/default.farm' immutability (if present)
checking existing 'conf.dispatcher.d/available_farms/default.farm' for changes
checking 'conf.dispatcher.d/cache/default_invalidate.any' immutability (if present)
replacing 'conf.dispatcher.d/cache/default_invalidate.any' content as it gets overridden on startup anyway
checking existing 'conf.dispatcher.d/cache/default_invalidate.any' for changes
checking 'conf.dispatcher.d/cache/default_rules.any' immutability (if present)
checking existing 'conf.dispatcher.d/cache/default_rules.any' for changes
checking 'conf.dispatcher.d/clientheaders/default_clientheaders.any' immutability (if present)
checking existing 'conf.dispatcher.d/clientheaders/default_clientheaders.any' for changes
checking 'conf.dispatcher.d/dispatcher.any' immutability (if present)
replacing include directive in 'conf.dispatcher.d/dispatcher.any' before proceeding
checking existing 'conf.dispatcher.d/dispatcher.any' for changes
checking 'conf.dispatcher.d/enabled_farms/farms.any' immutability (if present)
checking existing 'conf.dispatcher.d/enabled_farms/farms.any' for changes
checking 'conf.dispatcher.d/filters/default_filters.any' immutability (if present)
checking existing 'conf.dispatcher.d/filters/default_filters.any' for changes
checking 'conf.dispatcher.d/renders/default_renders.any' immutability (if present)
checking existing 'conf.dispatcher.d/renders/default_renders.any' for changes
checking 'conf.dispatcher.d/virtualhosts/default_virtualhosts.any' immutability (if present)
checking existing 'conf.dispatcher.d/virtualhosts/default_virtualhosts.any' for changes
no immutable file has been changed - check is SUCCESSFUL
Phase 3 finished successfully

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pankaj-parashar pankaj-parashar merged commit bfca023 into develop Oct 5, 2023
9 checks passed
@pankaj-parashar pankaj-parashar deleted the update-cloud-dispatcher-2.0.191 branch October 5, 2023 12:21
@pankaj-parashar pankaj-parashar added this to the 45 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants