Generic model needs to be kept in place as buildup of immutable state… #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is based on generic model
|
@DominikSuess - did not have the time to review it, but please check the failing tests first. |
rombert
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
Changes LGTM but I can't say I fully understand the implications. @cziegeler - what are your thoughts on this?
|
I think the change is ok, but I'm not 100% sure. If the IT tests still work, I guess we are fine |
cziegeler
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… is based on generic model
Description
Related Issue
Motivation and Context
Prune of models was too aggressive, not considering the usecase for a generic model (environment agnostic) while it is being used for build up of immutable repository. This only hits once all 3 specialized models are present (e.g. configs dedicated to dev,stage & prod) - this overoptimization only hits in this case otherwise there was always the generic model left
How Has This Been Tested?
Adjusted unittests to cover the scenario found downstream during implementation - validation of concrete testproject scenario.
Screenshots (if appropriate):
Types of changes
Checklist: