SLING-12197 - Fix lacking repoinit statements

[niekraaijmakers]

Description

Related Issue

#222

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[niekraaijmakers]

cc @cziegeler @DominikSuess @karlpauls @stefanseifert
ready for review.

[niekraaijmakers]

@mtilburgadobe fyi

[rombert]

Thanks a lot for taking the time to prepare this @niekraaijmakers ! I have two questions around the fix

• can you please create a GitHub issue in this repo and explain what the fix does?
• does it make sense to always generate the repoinit statements? When AEM users include the maven plugin in their builds, do they get anything out of this? They might, for instance, if we plan to start analysing repoinit statements, but want to make sure that this is a conscious decision

Thanks!

[stefanseifert]

great, thanks for the quick fix!

i've provided a small update PR to this which uses different versions of wcm.io handler JARs for testing - because in the latest versions we included a workaround for SLING-12197, and this PR uses older versions without that workaround.
#221

[niekraaijmakers]

Thanks a lot for taking the time to prepare this @niekraaijmakers ! I have two questions around the fix

• can you please create a GitHub issue in this repo and explain what the fix does?
• does it make sense to always generate the repoinit statements? When AEM users include the maven plugin in their builds, do they get anything out of this? They might, for instance, if we plan to start analysing repoinit statements, but want to make sure that this is a conscious decision

Thanks!

Il create a github issue. The idea is to keep the local & integrated build aligned as much as possible.