In case of duplicate bundles, re-version the product bundle #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Require at least Apache Maven 3.8.1 * Update docs * Correct java version required
…#233) Bumps [org.codehaus.plexus:plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.6.0 to 4.8.0. - [Release notes](https://github.com/codehaus-plexus/plexus-archiver/releases) - [Changelog](https://github.com/codehaus-plexus/plexus-archiver/blob/master/ReleaseNotes.md) - [Commits](codehaus-plexus/plexus-archiver@plexus-archiver-4.6.0...plexus-archiver-4.8.0) --- updated-dependencies: - dependency-name: org.codehaus.plexus:plexus-archiver dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…affected by SLING-12197 (#221)
…es-plugin to v3.3.1 (#235) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…-plugin to v3.1.2 (#234) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
#238) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…admin to v1.9.26 (#241) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…n to v2.0.6 (#240) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
Closing in favour of #244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two features are merged and both contain the exact same artifact (exact same mvn coordinates), then the resulting feature has that artifact only once - as it is the same.
With this patch, if the user feature and the product feature both contain the exact same bundle, this is checked after the features are merged and then the product bundle is re-versioned to 1.0.0.AEM-ANALYSER and the user bundle is added at the end.
Note: the code needs some cleanup.
@rombert While this works for the pure analysing use cases, are you aware of other use cases of this code where it might break that part?