Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining legacy plexus components #251

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Remove remaining legacy plexus components #251

merged 1 commit into from
Aug 6, 2024

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Jul 26, 2024

This relates to #206

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@kwin kwin force-pushed the bugfix/remove-plexus-components branch from dfc2090 to 97f94ce Compare July 26, 2024 16:09
@kwin kwin force-pushed the bugfix/remove-plexus-components branch from 97f94ce to 0a2faaf Compare July 26, 2024 16:33
@kwin
Copy link
Contributor Author

kwin commented Jul 31, 2024

@cziegeler Can you review this?

cziegeler
cziegeler approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@cziegeler cziegeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kwin - looks good to me. I'll merge after the next release of the plugin which should happen shortly

@cziegeler cziegeler merged commit 4071e1e into adobe:main Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cziegeler cziegeler cziegeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwin @cziegeler