Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyser to check for implementating or extending ProviderType interfaces from AEM #267

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

cziegeler
Copy link
Contributor

This closes #264

Add a new feature model analyser which scans the user class files if any of them implements an AEM provided ProviderType. The list of ProviderType is part of the AEM SDK API.

Motivation and Context

This allows to get a warning already in the local build, avoiding the need to run a quality pipeline. In addition, all code is checked by this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cziegeler cziegeler merged commit 880e2de into main Jul 29, 2024
3 checks passed
@cziegeler cziegeler deleted the issue-264 branch July 29, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add analyser to check for implementating or extending ProviderType interfaces from AEM
1 participant