Handle Undeploy for UI only apps

src/commands/app/undeploy.js

@@ -12,6 +12,7 @@ governing permissions and limitations under the License.
 
 const ora = require('ora')
 const chalk = require('chalk')
+const fs = require('fs-extra')
 // const path = require('path')
 
 const { flags } = require('@oclif/command')
@@ -59,7 +60,11 @@ class Undeploy extends BaseCommand {
 
       // undeploy
       if (!flags.static) {
-        await scripts.undeployActions()
+        if (fs.existsSync('manifest.yml')) {
+          await scripts.undeployActions()
+        } else {
+          this.log('no action src, skipping action undeploy')
+        }
       }
       if (!flags.actions) {
         await scripts.undeployUI()

test/commands/app/undeploy.test.js

@@ -13,10 +13,13 @@ governing permissions and limitations under the License.
 const TheCommand = require('../../../src/commands/app/undeploy')
 const BaseCommand = require('../../../src/BaseCommand')
 
+const mockFS = require('fs-extra')
+
 // mocks
 const mockScripts = require('@adobe/aio-app-scripts')()
 
 beforeEach(() => {
+  mockFS.existsSync.mockReset()
   jest.restoreAllMocks()
 })
 
@@ -48,6 +51,7 @@ test('flags', async () => {
 describe('run', () => {
   let command
   beforeEach(() => {
+    mockFS.existsSync.mockReset()
     command = new TheCommand([])
     command.error = jest.fn()
   })
@@ -57,13 +61,15 @@ describe('run', () => {
   })
 
   test('undeploy an App with no flags', async () => {
+    mockFS.existsSync.mockReturnValue(true)
     await command.run()
     expect(command.error).toHaveBeenCalledTimes(0)
     expect(mockScripts.undeployActions).toHaveBeenCalledTimes(1)
     expect(mockScripts.undeployUI).toHaveBeenCalledTimes(1)
   })
 
   test('undeploy an App with --verbose', async () => {
+    mockFS.existsSync.mockReturnValue(true)
     command.argv = ['-v']
     await command.run()
     expect(command.error).toHaveBeenCalledTimes(0)
@@ -72,6 +78,7 @@ describe('run', () => {
   })
 
   test('undeploy only actions', async () => {
+    mockFS.existsSync.mockReturnValue(true)
     command.argv = ['-a']
     await command.run()
     expect(command.error).toHaveBeenCalledTimes(0)
@@ -80,6 +87,7 @@ describe('run', () => {
   })
 
   test('undeploy only actions --verbose', async () => {
+    mockFS.existsSync.mockReturnValue(true)
     command.argv = ['-a']
     await command.run()
     expect(command.error).toHaveBeenCalledTimes(0)
@@ -104,18 +112,19 @@ describe('run', () => {
   })
 
   test('should fail if scripts.undeployActions fails', async () => {
+    mockFS.existsSync.mockReturnValue(true)
     const error = new Error('mock failure')
     mockScripts.undeployActions.mockRejectedValue(error)
     await command.run()
     expect(command.error).toHaveBeenCalledWith(error)
     expect(mockScripts.undeployActions).toHaveBeenCalledTimes(1)
   })
 
-  test('should fail if scripts.undeployUI fails', async () => {
-    const error = new Error('mock failure')
-    mockScripts.undeployUI.mockRejectedValue(error)
+  test('undeploy an App with no backend', async () => {
+    mockFS.existsSync.mockReturnValue(false)
     await command.run()
-    expect(command.error).toHaveBeenCalledWith(error)
-    expect(mockScripts.undeployUI).toHaveBeenCalledTimes(0)
+    expect(command.error).toHaveBeenCalledTimes(0)
+    expect(mockScripts.undeployActions).toHaveBeenCalledTimes(0)
+    expect(mockScripts.undeployUI).toHaveBeenCalledTimes(1)
   })
 })