Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime lib2 #280

Merged
merged 37 commits into from
Sep 10, 2020
Merged

Runtime lib2 #280

merged 37 commits into from
Sep 10, 2020

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Aug 10, 2020

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@purplecabbage purplecabbage marked this pull request as ready for review September 1, 2020 17:27
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #280 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #280    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           22        26     +4     
  Lines          792      1235   +443     
  Branches       106       214   +108     
==========================================
+ Hits           792      1235   +443     
Impacted Files Coverage Δ
src/commands/app/deploy.js 100.00% <100.00%> (ø)
src/commands/app/get-url.js 100.00% <100.00%> (ø)
src/commands/app/logs.js 100.00% <100.00%> (ø)
src/commands/app/run.js 100.00% <100.00%> (ø)
src/commands/app/undeploy.js 100.00% <100.00%> (ø)
src/lib/app-helper.js 100.00% <100.00%> (ø)
src/lib/config-loader.js 100.00% <100.00%> (ø)
src/lib/owlocal.js 100.00% <100.00%> (ø)
src/lib/poller.js 100.00% <100.00%> (ø)
src/lib/runDev.js 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c4ca4...bedb32c. Read the comment docs.

@meryllblanchet meryllblanchet removed the request for review from moritzraho September 7, 2020 13:24
@purplecabbage purplecabbage merged commit 9ab5030 into adobe:master Sep 10, 2020
@purplecabbage purplecabbage deleted the runtime-lib2 branch September 10, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants