Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app config rename #331

Merged
merged 6 commits into from
Dec 2, 2020
Merged

fix: app config rename #331

merged 6 commits into from
Dec 2, 2020

Conversation

rajarju
Copy link
Contributor

@rajarju rajarju commented Nov 25, 2020

Description

Rename firefly app configuration key for .aio file to app

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #331 (4713e0d) into master (f7e43b2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #331   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         1270      1274    +4     
  Branches       209       210    +1     
=========================================
+ Hits          1270      1274    +4     
Impacted Files Coverage Δ
src/lib/config-loader.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e43b2...4713e0d. Read the comment docs.

@shazron
Copy link
Member

shazron commented Nov 26, 2020

Unfortunately, we will also need to be backwards compatible and support the cna property still, and print out a deprecation message it if someone accesses it. We can remove it if we publish a major version.

@rajarju
Copy link
Contributor Author

rajarju commented Nov 26, 2020

@shazron Just what we were discussing
I have added a sample text for the warning

@rajarju rajarju marked this pull request as ready for review November 26, 2020 07:33
@shazron shazron merged commit 972de94 into master Dec 2, 2020
@shazron shazron deleted the rajarju/app-config-rename branch December 2, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants