Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACNA-976 - feat: add new app event hooks for custom build scripts #340

Merged
merged 6 commits into from
Dec 4, 2020

Conversation

shazron
Copy link
Member

@shazron shazron commented Dec 3, 2020

Fixes #339

How Has This Been Tested?

  • npm test
  • add build-actions and/or build-static run scripts in package.json for your app, run aio app build
  • add deploy-actions and/or deploy-static run scripts in package.json for your app, run aio app deploy

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

shazron and others added 3 commits December 3, 2020 21:10
the deploy-* and build-* scripts will throw an error on exception
if skip-static and skip-actions flags are both set, show a 'nothing to deploy/build' message
@shazron shazron marked this pull request as ready for review December 4, 2020 04:26
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #340 (5d2b00d) into master (5be4f39) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #340   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         1305      1329   +24     
  Branches       213       219    +6     
=========================================
+ Hits          1305      1329   +24     
Impacted Files Coverage Δ
src/commands/app/build.js 100.00% <100.00%> (ø)
src/commands/app/deploy.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be4f39...5d2b00d. Read the comment docs.

@shazron shazron requested a review from Himavanth December 4, 2020 04:34
@purplecabbage
Copy link
Member

Lgtm!
Why the long timeout?

@Himavanth
Copy link
Contributor

LGTM. Just two minor comments.

  • Jesse's comment on timeout
  • Should we make skip-static and skip-actions mutually exclusive just like skip-deploy and skip-build ? (would be a breaking change in another PR anyway)

@shazron
Copy link
Member Author

shazron commented Dec 4, 2020

Lgtm!
Why the long timeout?

ah, no need for the timeout actually after my tests. I thought some tests were failing because of timeout.

@shazron
Copy link
Member Author

shazron commented Dec 4, 2020

Should we make skip-static and skip-actions mutually exclusive

I agree. Like you mentioned this would be a breaking change so let's do it in another PR.
The only remote use-case I can see why someone would want to use both flags is if they want the pre and post hooks to run for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add new app event hooks for custom build scripts
3 participants