-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACNA-976 - feat: add new app event hooks for custom build scripts #340
Conversation
the deploy-* and build-* scripts will throw an error on exception if skip-static and skip-actions flags are both set, show a 'nothing to deploy/build' message
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 1305 1329 +24
Branches 213 219 +6
=========================================
+ Hits 1305 1329 +24
Continue to review full report at Codecov.
|
Lgtm! |
LGTM. Just two minor comments.
|
ah, no need for the timeout actually after my tests. I thought some tests were failing because of timeout. |
I agree. Like you mentioned this would be a breaking change so let's do it in another PR. |
Fixes #339
How Has This Been Tested?
build-actions
and/orbuild-static
run scripts inpackage.json
for your app, runaio app build
deploy-actions
and/ordeploy-static
run scripts inpackage.json
for your app, runaio app deploy
Types of changes
Checklist: