Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use of generator-aio-app/add-vscode-config generator #365

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

shazron
Copy link
Member

@shazron shazron commented Jan 25, 2021

How Has This Been Tested?

npm test
manual tests of aio app run (local and remote) with and without VS Code debugging

mkdir vscode-test
cd vscode-test

git clone https://github.com/adobe/generator-aio-app
cd generator-aio-app
git checkout vscode
npm i
cd ..

git clone https://github.com/adobe/aio-cli-plugin-app
cd aio-cli-plugin-app
git checkout vscode-gen
npm i
npm link ../generator-aio-app
aio plugins link .
cd ..

aio app run

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron requested review from purplecabbage, Himavanth and moritzraho and removed request for Himavanth January 25, 2021 05:33
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #365 (ea2d732) into master (fad0a6d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #365   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         1446      1411   -35     
  Branches       233       226    -7     
=========================================
- Hits          1446      1411   -35     
Impacted Files Coverage Δ
src/lib/run-dev.js 100.00% <100.00%> (ø)
src/lib/run-local-runtime.js 100.00% <100.00%> (ø)
src/lib/vscode.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fad0a6d...ea2d732. Read the comment docs.

@shazron shazron merged commit 7eacde2 into master Jan 26, 2021
@shazron shazron deleted the vscode-gen branch January 26, 2021 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use new VS Code launch config generator
1 participant