Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated openwhisk.jar location #404

Merged
merged 2 commits into from
May 10, 2021
Merged

fix: updated openwhisk.jar location #404

merged 2 commits into from
May 10, 2021

Conversation

shazron
Copy link
Member

@shazron shazron commented May 10, 2021

Description

Fixes #374

Usage of GH for this: https://docs.github.com/en/github/managing-large-files/distributing-large-binaries

How Has This Been Tested?

Linked to a local app plugin then:
aio app run --local --verbose

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #404 (c803d46) into master (aa2e4ad) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #404   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         1695      1695           
  Branches       284       284           
=========================================
  Hits          1695      1695           
Impacted Files Coverage Δ
src/lib/owlocal.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa2e4ad...c803d46. Read the comment docs.

@shazron shazron requested review from Himavanth and moritzraho May 10, 2021 08:50
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the cleanest way, thanks Shaz

@shazron shazron merged commit 21b8b3e into master May 10, 2021
@shazron shazron deleted the ow-jar-update branch May 10, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move openwhisk-standalone.jar off bintray (service shutting down)
3 participants