Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nodejs-v14 support for local openwhisk #405

Merged
merged 2 commits into from
May 17, 2021
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented May 12, 2021

see https://hub.docker.com/r/adobeapiplatform/adobe-action-nodejs-v14/tags

Description

Adds nodejs-14 runtime support for the local openwhisk.

How Has This Been Tested?

  1. Modify your runtime in your manifest.yml for node-14
  2. Run it using aio app run --local --verbose

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #405 (d44c044) into master (4d4e16d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #405   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         1695      1695           
  Branches       284       284           
=========================================
  Hits          1695      1695           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d4e16d...d44c044. Read the comment docs.

@shazron
Copy link
Member Author

shazron commented May 12, 2021

Tested locally on a Mac - the container is run, but I keep getting The action did not initialize and exited unexpectedly. (400 error, action developer error). The actions were built and packed using node-14. Actions on the node-12 runtime are successful.

@shazron
Copy link
Member Author

shazron commented May 12, 2021

Update: seems to be a transient issue. I can't repro it anymore. @Himavanth managed to repro initially but then it went away (not sure the cause)

@shazron shazron marked this pull request as ready for review May 12, 2021 10:22
@shazron shazron merged commit 7f754d7 into master May 17, 2021
@shazron shazron deleted the node14-local-ow branch May 17, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant