Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

an action with annotation web-export: raw should be considered a web action in getActionUrl #188

Closed
shazron opened this issue Apr 28, 2024 · 1 comment · Fixed by #189
Closed
Labels
bug Something isn't working

Comments

@shazron
Copy link
Member

shazron commented Apr 28, 2024

See:

const webArg = action['web-export'] || action.web

Expected

If I set the annotation web-export for an action to raw, it is considered a web action url

Actual

If I set the annotation web-export for an action to raw, it is considered a non-web action url

Fix

  1. add a failing test
  2. Replace the quoted line above with const webArg = action?.annotations?.['web-export'] || action?.web
@shazron shazron added the bug Something isn't working label Apr 28, 2024
@aiojbot
Copy link
Collaborator

aiojbot commented Apr 28, 2024

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants