From 05e7252fce41b5a012310d6dbad9798f86c7dadb Mon Sep 17 00:00:00 2001 From: Erik Tierney Date: Wed, 15 May 2013 10:35:45 -0400 Subject: [PATCH] Fix crash when hinting with angular.js. Updated to a version of tern that fixes the bug. Take out the excludes of minified libraries, as they all work now that the bug is fixed. Stil exclude require and jquery files since we have json defs files for those that have better type information. Fixes Issue #3827 --- src/extensions/default/JavaScriptCodeHints/ScopeManager.js | 4 ++-- src/extensions/default/JavaScriptCodeHints/thirdparty/tern | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/extensions/default/JavaScriptCodeHints/ScopeManager.js b/src/extensions/default/JavaScriptCodeHints/ScopeManager.js index 5de17df2939..a6c78bad5a8 100644 --- a/src/extensions/default/JavaScriptCodeHints/ScopeManager.js +++ b/src/extensions/default/JavaScriptCodeHints/ScopeManager.js @@ -57,8 +57,8 @@ define(function (require, exports, module) { numResolvedFiles = 0, numAddedFiles = 0, stopAddingFiles = false, - excludedFilesString = "require\\.js$|jquery-[\\d]\\.[\\d]\\.js$|\\.min\\.js$", - excludedFilesRegEx = new RegExp(excludedFilesString), + // exclude require and jquery since we have special knowledge of those + excludedFilesRegEx = /require\.js$|jquery-[\d]\.[\d]\.js$/, _ternWorker = (function () { var path = ExtensionUtils.getModulePath(module, "tern-worker.js"); return new Worker(path); diff --git a/src/extensions/default/JavaScriptCodeHints/thirdparty/tern b/src/extensions/default/JavaScriptCodeHints/thirdparty/tern index d5289c7f0c4..adc1e500288 160000 --- a/src/extensions/default/JavaScriptCodeHints/thirdparty/tern +++ b/src/extensions/default/JavaScriptCodeHints/thirdparty/tern @@ -1 +1 @@ -Subproject commit d5289c7f0c42b0aed3e1ccfd608db1fee15042f0 +Subproject commit adc1e500288c2400fbd9fc4181ac989a517dde5f