Use constants for keyCodes

[tvoliter]

Most of Brackets code that looks at the keyCode member of an event compares it against the keyCode number. Brackets could would be more readable if keycode constants were used instead.

References regarding constants and keyCodes
http://www.javascripter.net/faq/keyeventconstantsfirefox.htm
http://stackoverflow.com/questions/1465374/javascript-event-keycode-constants

[peterflynn]

There's more of this in the unit tests now too... see the tests added by pull #1273, for example.

[couzteau]

Hi brackets people. Looking into fixing this issue- Jochen

[couzteau]

This is an easy fix but I wonder what the preferred place to define key constants would be. Do you want them in utils.Globals.js?

[couzteau]

I suppose a better place might be to put constants into a KeyEvent class in utils? Thanks for a quick comment.

[redmunds]

Joschen, Thanks for taking this on. I marked it as "Fix in Progress". Yes, I think a KeyEvent module in utils is perfect.

[couzteau]

Pull request pending.

[jasonsanjose]

FBNC to @jasonsanjose

[jasonsanjose]

Confirmed fixed by pull request #1583.