Incorrect auto-complete values for the font-variant CSS property

[arnog]

The auto-complete for the font-variant CSS property is incorrect. We offer "none" and "normal", while the valid values for this property are "small-caps", "normal" and "inherit".

[jasonsanjose]

Reviewed. Low priority starter bug. See src/extensions/default/CSSCodeHints/CSSProperties.json.

[tshaddix]

Would it be this simple? (line 102)

Before:

"font-variant":                {"values": ["normal", "none"]},

After:

"font-variant":                {"values": ["small-caps", "normal", "inherit"]},

[RaymondLim]

@tshaddix
Yes, it is. But if you can take this chance to review the accuracy of other property values, that will be great.

[tshaddix]

@RaymondLim
Sounds good. I'll take a look at the other values as well.

[tshaddix]

I noticed some properties have "structure" helpers for more complex values, such as background-image which has the helper linear-gradient(). Would it be appropriate to do the same with the different ways to define color values?

e.g.

    "color": {"values": ["currentColor", "transparent", "inherit", "hsl()", "hsla()", "rgb()", "rgba()"]},

[RaymondLim]

@tshaddix
Sorry that I didn't notice your question earlier. I would say don't bother with those color formats as there are many properties that need those color formats and it is more efficient in auto generating them from JS instead of maintaining them in JSON file.

[tshaddix]

@RaymondLim
No problem. It's definitely more effective the centralize the generation rather than maintaining the color types for each property.

[tshaddix]

Had a lot of work come up lately, another "starter" should grab this bug. Simply look at css property specs and make sure json lines up.

[ghost]

I would like to fix this bug and also look at other CSS properties.
Is there a list of properties that we used to populate src/extensions/default/CSSCodeHints/CSSProperties.json file?

I am planning to use data from https://developer.mozilla.org/en-US/docs/Web/CSS/Reference. Anyone has a better data source?

[ghost]

So a little later I found out src/extensions/default/WebPlatformDocs/css.json which I think is the db right now.
But I am unable to locate the generator script for this db. Anyone?

[redmunds]

@skant

Is there a list of properties that we used to populate src/extensions/default/CSSCodeHints/CSSProperties.json file?

That file is currently manually updated. Submit a pull request for any changes.

I found out src/extensions/default/WebPlatformDocs/css.json which I think is the db right now.

That is the data for Navigate > Quick Docs. That was a recently added feature, so we have not yet made the generator public.

[ghost]

@redmunds
That generator could back feed css.json or you think CSSProperties.json is best maintained manually?

[adrocknaphobia]

@skant Quick Docs (WebPlatformDocs/css.json) is parsed from http://docs.webplaform.org. It's a community wiki where anyone can contribute and edit the documentation. I'm not convinced it's structured enough to form the basis of code hinting.

[ghost]

@adrocknaphobia In that case we need a better source to feed CSSProperties.json. Digging into source of Firebug, etc might help. Anyone knows a good source from the top of their head?

[jh3y]

I'd be interested to see where this goes. I think any of the browser dev tools are probably best to look at. I'll have a quick look around and see what I find.

@jheytompkins