Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Core][Search replace panel]: The search replace panel will get truncated if the find-replace-title is too long. #4870

Closed
julieyuan opened this issue Aug 22, 2013 · 6 comments
Assignees
Labels

Comments

@julieyuan
Copy link

Steps:

  1. Launch Brackets and open a file.
  2. Click Edit >Replace to invoke the Replace bar on the top.
  3. Input one long string , then press Enter.
  4. Input another long string which you want to use to replace the first string, then press Enter.
  5. Click button All and observe the Search-replace-panel.

Result:
The search-replace-panel is truncated.

Expected:
UI should display well.

ENV: MAC10.8 and Win8 English OS
Build: 0.30.0-8827

Snapshot:
Please refer to snapshot for details:
capture dcran 2013-08-21 19 31 33

@zaggino
Copy link
Contributor

zaggino commented Aug 22, 2013

Pull #4661 waiting for @larz0 to review, similar solution can be then applied here.

@TomMalbran
Copy link
Contributor

I was thinking the same thing :)

@TomMalbran
Copy link
Contributor

FBNC @julieyuan

@ghost ghost assigned julieyuan Aug 22, 2013
@julieyuan
Copy link
Author

Hi, thanks for all your efforts. I checked this issue in latest build 0.30.0-8873, the UI has changed, but I'm sorry to see this issue still happening. Here is the snapshot for reference:
capture dcran 2013-08-25 18 53 59

@TomMalbran
Copy link
Contributor

FBNC again. @julieyuan can you test it please?

@ghost ghost assigned julieyuan Sep 6, 2013
@julieyuan
Copy link
Author

Fixed in latest build 0.31.0-9351. Great job! Here is the snapshot:
screen shot 2013-09-10 at 12 06 28 am

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants