Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Core][layout issue]: The layout of bottom panel and selected file seem strange when drag the left sidebar. #5507

Closed
julieyuan opened this issue Oct 14, 2013 · 12 comments
Assignees

Comments

@julieyuan
Copy link

Steps:

  1. Launch Brackets.
  2. Press Ctrl+Shift+F to bring up search bar on the top, input some string to search it in the project.
  3. Make sure the project has the string you are searching to bring up the search result panel on the bottom.
  4. Drag the right side of Bracket window to the left to resize the window.
  5. Then drag the left sidebar to the right and observer the bottom panel.

Result:
At step5, the close icon on the bottom panel will move to left, even it can be at the head of the panel title. And when the left sidebar meet the right sidebar, the layout is strange.

Expect:
There is no layout issue.

ENV: MAC10.9 and Win7 English OS
Build: 0.33.0-9858

Snapshots:
Here are the snapshots for details:
screen shot 2013-10-14 at 1 26 31 am

33

@ghost ghost assigned bchintx Oct 14, 2013
@njx
Copy link

njx commented Oct 14, 2013

Low priority to @bchintx. We should enforce some kind of maximum width constraint on the left sidebar so it can't completely obliterate the code area.

@bchintx
Copy link
Contributor

bchintx commented Dec 17, 2013

Fix submitted in two pull requests: Brackets PR #5660 and Brackets-Shell PR #400.

@ingorichter
Copy link
Contributor

@bchintx This looks much better now. The weird layout issues are gone and the panel is displaying the content as good as it's possible. I don't know if I should merge it still, since Peter added a comment to the issue.

@bchintx
Copy link
Contributor

bchintx commented Jan 6, 2014

Withdrew previous pull requests and submitted a simpler change in Pull Request #6380. Rather than restricting the resizing of the window and the side panel, set the 'overlap: hidden' style on the 'content' class so that the panel adornments are correctly hidden.

@bchintx
Copy link
Contributor

bchintx commented Jan 13, 2014

I've just closed issue #6238 as a Duplicate of this bug, since it is reporting basically the same behavior.

peterflynn added a commit that referenced this issue Jan 15, 2014
Fix issue #5507- "[Core][layout issue]: The layout of bottom panel and selected file seem strange when drag the left sidebar."
@peterflynn
Copy link
Member

FBNC @julieyuan via #6380

@julieyuan
Copy link
Author

The fix has not merged into latest build 0.36.0-11258 yet, will check it again with next build.

@ghost ghost assigned julieyuan Jan 16, 2014
@julieyuan
Copy link
Author

Confirm this issue fixed with build 0.36.0-11286. Thanks a lot. Closing it and here is the snapshot for reference:
screen shot 2014-01-15 at 6 27 18 pm

peterflynn added a commit that referenced this issue Jan 16, 2014
Fix issue #6552- "Renderring issue in Result panel after renaming a file in the project tree." (but reopen #5507 & part of #6238)
@peterflynn
Copy link
Member

Reopening -- we had to back out #6380 due to issue #6552

@peterflynn peterflynn reopened this Jan 16, 2014
@ghost ghost assigned bchintx Jan 16, 2014
@bchintx
Copy link
Contributor

bchintx commented Jan 17, 2014

Merged PR #6569, which, in addition to fixing #6380, also fixes this issue. Marking FBNC for @julieyuan

@ghost ghost assigned julieyuan Jan 17, 2014
@julieyuan
Copy link
Author

The fix has not merged the latest build which I can get 0.36.0-11415 yet. Will check it again with next build. Thanks.

@julieyuan
Copy link
Author

Confirm this issue fixed with build 0.36.0-11462. Thanks a lot. Closing it and here is the snapshot for reference:
44

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants