Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Inline Editor no longer closes cleanly #6756

Closed
redmunds opened this issue Feb 4, 2014 · 14 comments
Closed

Inline Editor no longer closes cleanly #6756

redmunds opened this issue Feb 4, 2014 · 14 comments

Comments

@redmunds
Copy link
Contributor

redmunds commented Feb 4, 2014

I am seeing this in both release and master branches.

Recipe

  1. Open a css inline editor with Ctrl-E
  2. Press Ctrl-E again to close it

Results
Editor starts transition to close, then opens up again, before finally closing (with no transition).

@njx
Copy link

njx commented Feb 4, 2014

I'm not seeing this on Mac with master. Are you on Win? Also, did you git submodule update when switching back to master (if you've been working on cmv4)? There do seem to be some timing issues in the cmv4 branch.

@peterflynn
Copy link
Member

@redmunds Is focus left inside the inline editor when you do step 2? If so, it's UTR for me too (Win 7, on master).

@redmunds
Copy link
Contributor Author

redmunds commented Feb 4, 2014

Inline editor successfully closes, just not cleanly, so it's not possible for focus to be left inside editor. Maybe I wasn't clear.

@redmunds
Copy link
Contributor Author

redmunds commented Feb 4, 2014

@njx I'm on Win7. git submodule is up-to-date.

@peterflynn
Copy link
Member

@redmunds Sorry, I meant before you do step 2. After step 1 (initial ctrl+E), focus is moved into the inline editor. I assume you then immediately do step 2 (second ctrl+E), while focus is still inside the inline editor. Correct? If I follow those steps, it's UTR for me -- it smoothly animates closed and that's it.

@njx
Copy link

njx commented Feb 4, 2014

Weird. I can't repro on Win 7 either.

@RaymondLim
Copy link
Contributor

I can't repro on Win 7 and Mac 10.8.5.

@redmunds
Copy link
Contributor Author

redmunds commented Feb 4, 2014

@peterflynn Yes, everything else behaves as designed. I even used "Reload Without Extensions" to make sure it wasn't an extension conflict.

I see it transition toward closing, then transition back to toward open, then it closes with no transition.

@JeffryBooher
Copy link
Contributor

I can't repro on Windows 8

@redmunds
Copy link
Contributor Author

redmunds commented Feb 4, 2014

Doesn’t seem to happen in Getting Started or Smoke Test pages. It only happens with a particular page I have -- which is a version of Citrus Café with JS and a few other things that were stripped out of our smoke test version.

@bchintx
Copy link
Contributor

bchintx commented Feb 5, 2014

Not seeing it either on Win 7 64-bit. I've tried to repro w/ Getting Started and the stock citrus completed projects.

@njx njx self-assigned this Feb 5, 2014
@njx
Copy link

njx commented Feb 5, 2014

To me, low pri for now since it seems like it's not generally reproducible.

@redmunds
Copy link
Contributor Author

See #6682 for more details about what is causing this.

@redmunds
Copy link
Contributor Author

Confirmed. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants