This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Keyboard Controls for Quick Editors Unit Tests #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| var editor, | ||
| pos = {line: 3, ch: 1}, | ||
| lineBefore, | ||
| lineAfter; |
There was a problem hiding this comment.
- lineAfter is unused
- lineBefore is assigned but never read, so I think it can be removed also
| // get text before insert operation | ||
| lineBefore = editor.document.getLine(pos.line); | ||
|
|
||
| CodeHintManager.handleKeyEvent(editor, e); |
There was a problem hiding this comment.
Since we have this simulateKeyEvent() utility now, would it be cleaner / more consistent to use it here too?
There was a problem hiding this comment.
Randy mentioned that this one requires a modifier key (Ctrl), and it seems nontrivial to add modifier-key support to simulateKeyEvent()... so it's fine by me to leave this as-is.
|
Done reviewing |
|
done with updates |
|
Great! Merging now. Good catch on adding that extra check to InlineEditorProviders-test, btw... |
peterflynn
added a commit
that referenced
this pull request
Jul 19, 2012
Unit Tests for Esc key handling (Quick Editors, code hints, and context menu) Also, add new utility to SpecRunnerUtils for simulating key events
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new function to SpecRunnerUtils for simulating keyboard events. Currently no way to specify modifier keys.
Added test to close an inline editor via Esc key. There are currently no unit tests for multiple inline editors, so there is no test for closing more than 1 via Esc key.
Added test for code hints.
Added test for closing context-menu via Esc Key. Opened issue #1270 for contextMenuClose event. There are no unit tests for closing main menus, so no tests were added for Esc key.