-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add third-party and CC-BY license URLs for 'tr' locale #4808
Conversation
|
||
define({ | ||
// Relative to the samples folder | ||
"GETTING_STARTED" : "tr/Erste Schritte", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed since there isn't any such sample currently. (It will fall back to the default English sample.)
Review complete. I can merge this when you've made these changes. Thanks. |
Oh, it looks like you also need to add an entry for this in |
Yep. Had to do that for Finnish here #5038. |
This looks fine, but it turns out that the two links actually don't work in the About dialog because the links are actually incorrect in the strings file. I'm going to fix that, then squash all these commits into a single update. |
Actually, it looks like we don't even have a translation for @Cryptexx - would you consider updating the Turkish strings.js file with translations for new strings since the last time it was updated? If so, please put up a new pull request for that. Thanks. |
No description provided.